Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WStrings message #4

Merged
merged 1 commit into from
May 2, 2019
Merged

add WStrings message #4

merged 1 commit into from
May 2, 2019

Conversation

dirk-thomas
Copy link
Member

Connect to ros2/rosidl#352.

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas self-assigned this May 2, 2019
msg/WStrings.msg Show resolved Hide resolved
@dirk-thomas dirk-thomas merged commit 0577b9b into master May 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the wstring branch May 2, 2019 18:48
@adamsj-ros
Copy link

why is this part of test_msgs and not a built-in type?

https://index.ros.org/doc/ros2/Concepts/About-ROS-Interfaces/#field-types

@jacobperron
Copy link
Member

why is this part of test_msgs and not a built-in type?

wstring is a built-in type. It was added in ROS Dashing. Here's the design doc: http://design.ros2.org/articles/wide_strings.html

This PR introduces a message for testing the built-in type.

It looks like the ROS Index page is missing info on wstring. I've opened a ticket for adding it: ros2/ros2_documentation#620

@adamsj-ros
Copy link

Shouldn't it be in std_msgs too to be considered a built-in type?

@dirk-thomas
Copy link
Member Author

@adamsj-oci there is a difference between built-in types and messages. A built-in type can be used as a field type in a message but is itself not a message.

@adamsj-ros
Copy link

@dirk-thomas That makes sense but at the same time it seems logical to have a Wstring.msg in a similar way we have String.msg if nothing else to support special characters in non-English languages.

@jacobperron
Copy link
Member

jacobperron commented Apr 22, 2020

I agree that it makes sense to add a WString.msg alongside the existing String.msg. However, note there's an open ticket proposing to move many of the messages in std_msgs to a different package. I'm not sure if the plan is to move String.msg as well.

ros2/common_interfaces#89

@dirk-thomas
Copy link
Member Author

it seems logical to have a Wstring.msg in a similar way we have String.msg if nothing else to support special characters in non-English languages.

This package as the name indicates is only for tests. You should create your own message definition to give the interface semantic meaning - for the same reason why you shouldn't use std_msgs in your packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants