Add rosbag2 to ros variants #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wasn't sure whether it best belongs to `ros_core`, but ultimately settled on `ros_base`.
|
from pre-waffle triagge: @Karsten1987 Can you assign yourself in this one? |
3 tasks
|
@nuclearsandwich just a friendly ping |
jacobperron
approved these changes
Feb 27, 2020
|
This looks good to me! I was just thinking "we should get rosbag in a variant" and here you're way ahead of me :) |
emersonknapp
approved these changes
Mar 4, 2020
|
Forgive me for asking rather than digging for myself, but does rosbag2 depend (either directly or indirectly) on the ros1_bridge and therefore ROS 1? If so that's quite heavyweight for ros_base. |
|
It does not. The rosbag2_bag_v2 plugin lives in its own repository. |
nuclearsandwich
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure whether it best belongs to
ros_core, but ultimately settled onros_base.