add support for 32bit/m depth encoding #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the changes described in #5 to add support for depth data encoded as 32bit floats.
The code checks for the encoding on the depth topic (if
use_depth
is true) by waiting 10s for a depth message. If the 10s timeout is reached, the encoding defaults to the original16UC1
.I am not a huge fan of
rospy.wait_for_message
but I find more reasonable to add a little overhead than re-reading the (same) encoding from each and every Image msg.