Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onboarding.service.spec.ts has lint issues #45

Closed
miller45 opened this issue May 16, 2019 · 2 comments · Fixed by #46
Closed

onboarding.service.spec.ts has lint issues #45

miller45 opened this issue May 16, 2019 · 2 comments · Fixed by #46
Assignees
@SDohle
Labels
infrastructure Project settings / build environment

Comments

@miller45
Copy link
Contributor

miller45 commented May 16, 2019 •
edited
Loading

Just ran the the npm lint job and this is what showed up:

ERROR: ngx-onboarding/projects/ngx-onboarding/src/lib/services/onboarding.service.spec.ts[32, 44]: variable 'getOnboardingItems' used before declaration
ERROR: ngx-onboarding/projects/ngx-onboarding/src/lib/services/onboarding.service.spec.ts[47, 28]: variable 'getHtmlElements' used before declaration
ERROR: ngx-onboarding/projects/ngx-onboarding/src/lib/services/onboarding.service.spec.ts[50, 46]: variable 'getOnboardingItems' used before declaration
ERROR: ngx-onboarding/projects/ngx-onboarding/src/lib/services/onboarding.service.spec.ts[64, 55]: variable 'getOnboardingItems' used before declaration
ERROR: ngx-onboarding/projects/ngx-onboarding/src/lib/services/onboarding.service.spec.ts[130, 40]: variable 'getOnboardingItems' used before declaration

We should adjust the tslint rules or push the constant to the top of the spec file...
Anyway, @SDohle why is our pull request build not running the lint job?
@SDohle SDohle self-assigned this May 17, 2019
@SDohle
Copy link
Member

SDohle commented May 17, 2019

I will check this

@SDohle SDohle mentioned this issue May 17, 2019
Merged
@SDohle
Copy link
Member

SDohle commented May 17, 2019

With PR #46 lint will be part of the build and the output will be:

ngx-onboarding-app@1.2.3 lint /home/vsts/work/1/s
ng lint

Linting "ngx-onboarding-app"...

All files pass linting.
Linting "ngx-onboarding-app-e2e"...

All files pass linting.
Linting "ngx-onboarding"...

All files pass linting.

@SDohle SDohle added the infrastructure Project settings / build environment label May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SDohle SDohle

Labels
infrastructure Project settings / build environment
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tslint rosen-group/ngx-onboarding
2 participants
@miller45 @SDohle