Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tslint #46

Merged
merged 3 commits into from
May 17, 2019
Merged

Tslint #46

merged 3 commits into from
May 17, 2019

Conversation

SDohle
Copy link
Member

@SDohle SDohle commented May 17, 2019

  • Enable lint in ci build
  • disable no-use-before-declare rule

Fixes #45

@SDohle
Run lint in build
c21e553
@SDohle
Disable no-use-before-declare rule:
0d1acf7 
This rule is primarily useful when using the var keyword since the compiler will automatically detect if a block-scoped let and const variable is used before declaration. Since most modern TypeScript doesn’t use var, this rule is generally discouraged and is kept around for legacy purposes. It is slow to compute, is not enabled in the built-in configuration presets, and should not be used to inform TSLint design decisions.
@SDohle SDohle mentioned this pull request May 17, 2019
Closed
miller45
miller45 approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@miller45 miller45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good and sound. Have a nice weekend

@miller45 miller45 merged commit ad189f3 into master May 17, 2019
@SDohle SDohle deleted the tslint branch May 17, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miller45 miller45 miller45 approved these changes

@alberst alberst Awaiting requested review from alberst

@MichaelKirchner MichaelKirchner Awaiting requested review from MichaelKirchner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onboarding.service.spec.ts has lint issues
2 participants
@SDohle @miller45