-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run 'haros init' in the build dir (instead of $HOME) #6
Comments
@git-afsantos: would Haros support storing everything in a directory not in I'm guessing the HarosInitRunner would need to be changed? |
Indeed, to support alternative directories I would have to make some changes. The single directory approach is something that has been bothering me too for a while. I am currently fixing some other issues in Haros, so I might tackle this right after. |
I don't necessarily just want to dump this on your TODO list. Do you have some ideas for what you'd like to change? The init runner seems straightforward enough. Adding an additional arg to the All the other verbs would probably also need to be extended to accept an additional arg telling them where the " |
Since this change affects all verbs, it is probably best for the argument to be passed to the haros --home /my/new/haros/dir <VERB> <ARGS> In terms of the code itself, the argument would be introduced around this line, with the default value of Then each verb runner (init, analyse, export, viz) would find & replace |
This line would have to be changed as well: |
@gavanderhoorn is your suggestion to place The latter requires a little bit more work to implement. |
git-afsantos/haros#71 is a candidate PR to implement this. |
the latter. But the former could be a work-around for now. |
git-afsantos/haros#71 has been updated. The directory given to Additionally, Released in Haros 3.5.0. |
As I mentioned in the meeting we just had: this wasn't directly related to running multiple Haros instances in parallel, but it should make it possible, yes, and that is actually going to help quite a bit later on. Primary motivation was to be able to put the |
@git-afsantos: I'm using Haros with git-afsantos/haros#71 (ie: v3.5.2) and the initial But a subsequent
all directories exist and Any ideas? PS: would you want me to open an issue on the haros tracker? |
Wow, you ran into two bugs at once! Good catch! So, basically, it was looking for the default |
Nice. I'll test. Thanks for the quick fixes. Btw, I noticed that the github repo releases page doesn't appear to list all releases that pypi has. Is that intentional? |
That is just me remembering the existence of that page only when I have a somewhat major release on my hands. Thanks for the reminder, I should update it sometime soon. 👍 |
Seems to work now, but I'm seeing Afaict I |
Yes, when I added the |
I'm not entirely sure yet, but I believe not running I'll verify and report back. |
Ah, I see. Given your command above, it is probably complaining with
I should be able to fix that soon. |
Yes, indeed. That's the error:
|
Haros 3.5.5 should fix that 🚢 |
Yep, fixed. Thanks again. |
This is now supported in Haros, and we can configure it in |
Current implementation appears to run
haros init
without any special configuration, which would place all haros configuration and plugin meta-data in$HOME
of the current user.Perhaps OK for normal usage, but it might be better to not do that when run as part of a
catkin_make run_tests
run to avoid polluting a user's$HOME
and/or any existing haros installation.It's unclear whether
haros init
actually accepts alternative locations -- and whether "the rest" of haros accepts non-standard locations -- but that would be something to investigate.The text was updated successfully, but these errors were encountered: