The final except statement was activated a few times whilst performing a #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a big migration. It caused an exception because it was trying to unpack one value into two - which didn't work (Python 2.5) - The following, however, works.
|
Great, thanks for making the change! I haven't done any testing of this project in a while. What do you think about other exceptions that unpack into two values; should we change them too? ./management/connection.py: except socket.gaierror, (n, desc): |
rossdakin
added a commit
that referenced
this pull request
Sep 8, 2011
Fix exception that breaks with Python 2.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final except statement was activated a few times whilst performing a big migration. It caused an exception because it was trying to unpack one value into two - which didn't work (Python 2.5) - The change made in the file, however, works.