Assume initialisms aren't acronyms by default #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This scratches an itch we have with this library as well (for acronyms like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds broader support for initialisms. Currently, all initialisms are assumed to be pronounceable (e.g. NAFTA) so the a/an decision uses the same logic as lowercase words, with a list of overrides for non-pronounceable initialisms (e.g. NPC).
But overall it feels like the majority of all-uppercase words will not be pronounceable, so IMO the a/an decision should default to how the first letter is pronounced (e.g. "eff" for F), with a list of overrides for pronounceable all-caps words.
(I don't have any data to support that feeling though, so feel free to reject that part and I'll just put in overrides for the words that were causing me trouble 😃 )