New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export public interface in root package #51

Merged

asgeirrr merged 1 commit into rossumai:main from uhlikfil:main

Oct 11, 2023

Contributor

uhlikfil commented Oct 11, 2023

Importing stuff from internal subpackages like

from rossum_api.elis_api_client import ElisAPIClient
from rossum_api.api_client import APIClientError

always feels bad. :(

The standard is to "export" public interface in the root package like

from httpx import AsyncClient, HTTPStatusError


          feat: export public interface in root package

f85fc58

asgeirrr approved these changes

View reviewed changes

Collaborator

asgeirrr left a comment

I'm not sure if "it always feels bad" but it's a nice shortcut, thanks 👍

asgeirrr merged commit 977824f into rossumai:main

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet