[bug: #19, #22] Fix examples and v27 Jest support / ESM #23
Conversation
rossyman
added
documentation
| @@ -197,33 +200,50 @@ class SvelteJestAdder extends Adder { | |||
| Preset | |||
| .editJson('jest.config.json').merge({ | |||
| transform: { | |||
| '^.+\\.svelte$': ['svelte-jester', {preprocess: true}], | |||
| '^.+\\.svelte$': ['./node_modules/svelte-jester/dist/transformer.mjs', {preprocess: true}], | |||
There was a problem hiding this comment.
Can this not be just svelte-jester?
There was a problem hiding this comment.
Ah, I just saw your explanation on #19 (comment)
There was a problem hiding this comment.
Yeah it's a rather peculiar issue. I would've assumed that Jest would've somehow picked up the .mjs file automagically when the ESM flag is enabled, but it seems to be forcing the .cjs transformer usage.
|
|
||
| test('shows proper heading when rendered', () => { | ||
| const { getByText } = render(index); | ||
| expect(getByText('Hello world!')).toBeInTheDocument(); |
There was a problem hiding this comment.
I liked that this was testing the .svelte file before, but it was challenging that the content was not the same in the two SvelteKit templates. Perhaps we can update the SvelteKit templates so that there's some piece of shared content to solve that?
There was a problem hiding this comment.
Perhaps we could just test for Sveltekit? That would pass both templates.
There was a problem hiding this comment.
That sounds like a good solution to me!
There was a problem hiding this comment.
Yeah so I can rework the tests slightly to just look for "Sveltekit".
For non Jest DOM users, we can just use the toBeDefined() matcher on the result of getByText(), and similarly continue to use toBeInTheDocument() for Jest DOM users -- does sound like a better solution?
There was a problem hiding this comment.
yeah, that sounds like a good idea
|
Just FYI, we're planning on bringing back CJS support to |
Fix examples and v27 Jest support / ESM.
Changelog
--jsdomflag / option@jest-environmentdata-block, or to default tojsdomwithinjest.config.json.@typesare only installed if bothtsandjest-domoption are true--experimental-vm-modulesflag when running JestuseESMconfiguration property forts-jest.mjstransformer usage injest.config.jsonforsvelte-jester. See svelte-jester 2.x does not work #19 (comment).svelteextensions to JestextensionsToTreatAsEsm; and.tsdepending on the TS optionlibproperty withintsconfig.spec.jsonto extend fromtsconfig.json