[enhancement: #14] Compatibility with Vite import.meta #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossyman
force-pushed
the
enhancement/gh-14
branch
from
dd1ce6e
to
6a2ca34
Compare
|
Going to re-purpose the PR to update examples based on #23 (comment) |
LeoUrzua
reviewed
May 18, 2022
| @@ -5,7 +5,10 @@ | |||
| }, | |||
| "moduleNameMapper": { | |||
| "^\\$lib(.*)$": "<rootDir>/src/lib$1", | |||
| "^\\$app(.*)$": ["<rootDir>/.svelte-kit/dev/runtime/app$1", "<rootDir>/.svelte-kit/build/runtime/app$1"] | |||
| "^\\$app(.*)$": [ | |||
| "<rootDir>/.svelte-kit/dev/runtime/app$1", | |||
There was a problem hiding this comment.
The build folder was generated after npm run build and I am not sure how to generate the dev one but this is my folder content
I updated these lines to just "<rootDir>/.svelte-kit/runtime/app$1" and it was working for me, let me know what you think @rossyman
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compatibility with Vite
import.meta. There's a wider discussion ongoing about how to use runtime modules outside of the context of a built svelte application. I outlined the current solutions here: #14 (comment) and I'll continue to track sveltejs/kit#1485Resolves #14
Changelog
babel-plugin-transform-vite-meta-envdependency