Add beacon build args #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #13580: Add REACT_APP variables to workflow. |
pdeziel
commented
Feb 6, 2023
| REACT_APP_GIT_REVISION=${{ steps.vars.outputs.revision }} | ||
| REACT_APP_SENTRY_DSN=${{ secrets.REACT_APP_SENTRY_DSN }} | ||
| REACT_APP_SENTRY_ENVIRONMENT=production | ||
| REACT_APP_USE_DASH_LOCALE=false |
There was a problem hiding this comment.
It seems that the previous PR didn't actually add the QUARTERDECK_BASE_URL and TENANT_BASE_URL variables, not sure why but hopefully this works?
There was a problem hiding this comment.
@masskoder are you taking advantage of these environment variables in the Beacon UI code base?
bbengfort
approved these changes
Feb 7, 2023
| REACT_APP_GIT_REVISION=${{ steps.vars.outputs.revision }} | ||
| REACT_APP_SENTRY_DSN=${{ secrets.REACT_APP_SENTRY_DSN }} | ||
| REACT_APP_SENTRY_ENVIRONMENT=production | ||
| REACT_APP_USE_DASH_LOCALE=false |
There was a problem hiding this comment.
@masskoder are you taking advantage of these environment variables in the Beacon UI code base?
|
@pdeziel I removed my suggestions - it looks like we already have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
This adds the rest of the beacon UI build args so that the variables are accessible in the production container.
Fixes SC-13580
Type of change
Acceptance criteria
All required variables are present and the github secrets have also been added.
Author checklist
Reviewer(s) checklist