Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add beacon build args #179

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Add beacon build args #179

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a3f90d
add beacon build args
pdeziel Feb 6, 2023
3fc45aa
Merge branch 'main' into sc-13580
bbengfort Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/containers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,14 @@ jobs:
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
build-args: |
GIT_REVISION=${{ steps.vars.outputs.revision }}
REACT_APP_TENANT_BASE_URL=https://api.rotational.app/v1/
REACT_APP_QUARTERDECK_BASE_URL=https://auth.rotational.app/v1/
REACT_APP_ANALYTICS_ID=${{ secrets.REACT_APP_ANALYTICS_ID }}
REACT_APP_VERSION_NUMBER=${{ steps.vars.outputs.tag }}
REACT_APP_GIT_REVISION=${{ steps.vars.outputs.revision }}
REACT_APP_SENTRY_DSN=${{ secrets.REACT_APP_SENTRY_DSN }}
REACT_APP_SENTRY_ENVIRONMENT=production
REACT_APP_USE_DASH_LOCALE=false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the previous PR didn't actually add the QUARTERDECK_BASE_URL and TENANT_BASE_URL variables, not sure why but hopefully this works?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masskoder are you taking advantage of these environment variables in the Beacon UI code base?


- name: Sentry Release
if: startsWith(github.ref, 'refs/tags/v')
Expand Down
4 changes: 2 additions & 2 deletions containers/beacon/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ ARG REACT_APP_ANALYTICS_ID
ARG REACT_APP_VERSION_NUMBER
ARG REACT_APP_GIT_REVISION
ARG REACT_APP_SENTRY_DSN
ARG REACT_APP_SENTRY_ENVIRONMENT
ARG REACT_APP_USE_DASH_LOCALE
ARG REACT_APP_SENTRY_ENVIRONMENT="production"
ARG REACT_APP_USE_DASH_LOCALE="false"

# Build app with react-scripts
COPY web/beacon-app/ ./
Expand Down