Ensign CreateTopic RPC #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
Implements the CreateTopic RPC in the Ensign node.
This PR omits the use of the placement service, but does directly engage the store. It also adds authentication handlers and contexts to Ensign.
Fixes SC-13305
Type of change
Acceptance criteria
I deleted the checklist - but now files have been changed that will require review. Please ensure that the changes made are understandable and that they won't break any other system that depends on the components.
Note: this introduces a breaking change for the next time we deploy Ensign: API Keys will be required.