Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify Landing Page Build Args #36

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Modify Landing Page Build Args #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions .github/workflows/containers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,20 +289,21 @@ jobs:
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
build-args: |
REACT_APP_TENANT_BASE_URL=https://api.rotational.app/v1/
REACT_APP_QUARTERDECK_BASE_URL=https://auth.rotational.app/v1/
REACT_APP_ANALYTICS_ID=${{ secrets.REACT_APP_ANALTYICS_ID }}
REACT_APP_VERSION_NUMBER=${{ steps.vars.outputs.tag }}
REACT_APP_GIT_REVISION=${{ steps.vars.outputs.revision }}
REACT_APP_SENTRY_DSN=${{ secrets.REACT_APP_SENTRY_DSN }}
REACT_APP_SENTRY_ENVIRONMENT=production

# - name: Sentry Release
# if: startsWith(github.ref, 'refs/tags/v')
# uses: getsentry/action-release@v1
# env:
# SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
# SENTRY_ORG: ${{ secrets.SENTRY_ORG }}
# SENTRY_PROJECT: landing-page
# with:
# environment: production
# version: ${{ steps.vars.outputs.tag }}
- name: Sentry Release
if: startsWith(github.ref, 'refs/tags/v')
uses: getsentry/action-release@v1
env:
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
SENTRY_ORG: ${{ secrets.SENTRY_ORG }}
SENTRY_PROJECT: porthole
with:
environment: production
version: ${{ steps.vars.outputs.tag }}
1 change: 1 addition & 0 deletions containers/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ docker buildx build --platform $PLATFORM -t rotationalio/quarterdeck:$TAG -f $DI
docker buildx build \
--platform $PLATFORM \
-t rotationalio/landing-page:$TAG -f $DIR/landing-page/Dockerfile \
--build-arg REACT_APP_TENANT_BASE_URL="https://api.rotational.app/v1/" \
--build-arg REACT_APP_QUARTERDECK_BASE_URL="https://auth.rotational.app/v1/" \
--build-arg REACT_APP_ANALYTICS_ID=${REACT_APP_ANALYTICS_ID} \
--build-arg REACT_APP_VERSION_NUMBER=${TAG} \
Expand Down
1 change: 1 addition & 0 deletions containers/docker-compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ services:
context: ../
dockerfile: ./containers/landing-page/Dockerfile
args:
REACT_APP_TENANT_BASE_URL: "http://localhost:8080/v1/"
REACT_APP_QUARTERDECK_BASE_URL: "http://localhost:8088/v1/"
REACT_APP_ANALYTICS_ID: ${REACT_APP_ANALYTICS_ID}
REACT_APP_VERSION_NUMBER: v0.1.0-dev
Expand Down
1 change: 1 addition & 0 deletions containers/landing-page/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ COPY web/ensign-landing-page/yarn.lock ./
RUN yarn install --frozen-lockfile --check-files

# Set production environment variable for build context
ARG REACT_APP_TENANT_BASE_URL="https://api.rotational.app/v1/"
ARG REACT_APP_QUARTERDECK_BASE_URL="https://auth.rotational.app/v1/"
ARG REACT_APP_ANALYTICS_ID
ARG REACT_APP_VERSION_NUMBER
Expand Down