Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/implement as #90

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Feat/implement as #90

merged 1 commit into from
Dec 3, 2020

Conversation

sum2000
Copy link
Member

@sum2000 sum2000 commented May 18, 2020

adds support for #76

@sum2000 sum2000 requested a review from morningvera May 18, 2020 23:37
Copy link
Member

@morningvera morningvera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some info about this to the "error inspection" section of the readme?

eris.go Outdated Show resolved Hide resolved
eris.go Outdated Show resolved Hide resolved
eris.go Show resolved Hide resolved
eris_test.go Show resolved Hide resolved
@morningvera
Copy link
Member

@sum2000 any progress on this?

@sum2000
Copy link
Member Author

sum2000 commented Jun 8, 2020

Not yet, are we planning on another release? I'll like to postpone it until then. Preparing for certification in extra time

@morningvera
Copy link
Member

it doesn't seem like much work is left so i could take care of it if you're open to that. otherwise, i'd be fine with closing it for now and reopening when you have more time

@sum2000
Copy link
Member Author

sum2000 commented Jun 10, 2020

your call, I am fine with both options. if you need my input for anything then I suggest close and reopen and if you have time go for merging it.

@morningvera morningvera force-pushed the feat/implement-As branch 2 times, most recently from d1a559a to f867167 Compare December 3, 2020 03:59
@codecov-io
Copy link

codecov-io commented Dec 3, 2020

Codecov Report

Merging #90 (8fe089d) into master (9fba1e0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #90   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          283       256   -27     
=========================================
- Hits           283       256   -27     
Impacted Files Coverage Δ
eris.go 100.00% <100.00%> (ø)
stack.go 100.00% <0.00%> (ø)
format.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fba1e0...8fe089d. Read the comment docs.

@morningvera
Copy link
Member

closes #76

@morningvera morningvera deleted the feat/implement-As branch December 3, 2020 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants