You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PoolTogether (https://app.pooltogether.com/) data is not correctly represented in the Defi overview. This is because the zerion SDK seems to return "PLT" as the token (which rotki recognizes as "Plutus Defi"), so it's returning an incorrect crypto icon and value in the user's profit currency.
The real token depends on which pool (DAI or USDC) the user has deposited their funds into thus should be returned as plDAI or plUSDC, which are locked in value 1:1 to DAI and USDC respectively. Therefore the correct valuation here would be 45 plDAI = 45 USD = ~38 EUR.
Even if zerion returned the correct token names, though, the downside is that these tokens are not listed on coingecko or cryptocompare as they're not really "tradeable tokens" -- just proxies for DAI and USDC, so we cannot grab the icons and prices automatically. We will probably need to create aliases plDAI for DAI and plUSDC for USDC and then include the icons manually?
@isidorosp This probably should go along with #1120, and the "more resources" links should also go there.
But let me see if until full pool together support is possible we can do something in between for what we show in the DeFi overview. Let me check zerion's adapter contract. Can you DM me the address you used so that I can test?
LefterisJP
added a commit
to LefterisJP/rotkehlchen
that referenced
this issue
Sep 9, 2020
Problem Definition
PoolTogether (https://app.pooltogether.com/) data is not correctly represented in the Defi overview. This is because the zerion SDK seems to return "PLT" as the token (which rotki recognizes as "Plutus Defi"), so it's returning an incorrect crypto icon and value in the user's profit currency.
The real token depends on which pool (DAI or USDC) the user has deposited their funds into thus should be returned as plDAI or plUSDC, which are locked in value 1:1 to DAI and USDC respectively. Therefore the correct valuation here would be 45 plDAI = 45 USD = ~38 EUR.
Even if zerion returned the correct token names, though, the downside is that these tokens are not listed on coingecko or cryptocompare as they're not really "tradeable tokens" -- just proxies for DAI and USDC, so we cannot grab the icons and prices automatically. We will probably need to create aliases plDAI for DAI and plUSDC for USDC and then include the icons manually?
Another option of course is that we develop our own submodule (e.g. using their subgraph https://thegraph.com/explorer/subgraph/pooltogether/pooltogether or by querying the relevant contracts) and ignore the zerion results for pooltogether.
More resources:
https://defimarketcap.io/protocol/pool-together
https://etherscan.io/accounts/label/pooltogether
The text was updated successfully, but these errors were encountered: