Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Bitstamp crypto transactions #1863

Closed
vnavascues opened this issue Dec 4, 2020 · 1 comment
Closed

Add support for Bitstamp crypto transactions #1863

vnavascues opened this issue Dec 4, 2020 · 1 comment
Assignees
Labels
exchange Issues related to integration with an exchange
Milestone

Comments

@vnavascues
Copy link
Contributor

vnavascues commented Dec 4, 2020

As per Bitstamp API v2 documentation, the JSON returned by the user transactions endpoint does not include any chain-related data (e.g. txid, address). This data is obtained by requesting the crypto transactions endpoint.

Be aware the crypto transactions endpoint is not paginated like the user transactions one (e.g. it has no since_id).

Related #1856 and more specifically: #1856 (comment)

@LefterisJP LefterisJP added this to the v1.11.0 milestone Dec 5, 2020
@LefterisJP LefterisJP mentioned this issue Dec 5, 2020
3 tasks
@LefterisJP LefterisJP modified the milestones: v1.11.0, 1.13.0 Dec 30, 2020
@LefterisJP LefterisJP modified the milestones: v1.13.0, v1.15.0 Jan 17, 2021
@LefterisJP LefterisJP modified the milestones: v1.15.0, v1.17.0 Feb 17, 2021
@aspiers aspiers added the exchange Issues related to integration with an exchange label Feb 28, 2021
@LefterisJP LefterisJP modified the milestones: v1.17.0, v1.19.0 May 26, 2021
@LefterisJP LefterisJP modified the milestones: v1.19.0, v1.24.0 Jul 14, 2021
@yabirgb yabirgb added Exchange Addition Request Issue tracks the request of addition of a new exchange in Rotkehlchen and removed Exchange Addition Request Issue tracks the request of addition of a new exchange in Rotkehlchen labels Sep 18, 2021
@LefterisJP LefterisJP modified the milestones: v1.24.0, 1.28.0 Jan 3, 2022
@LefterisJP LefterisJP removed this from the 1.28.0 milestone Feb 7, 2023
@LefterisJP LefterisJP added this to the 1.31.2 milestone Dec 12, 2023
@LefterisJP LefterisJP self-assigned this Dec 12, 2023
LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this issue Dec 12, 2023
Fix rotki#1863

Achieve that by querying an extra endpoint for bitstamp
deposit/withdrawals. The crypto_transactions.

Unfortunately we need to query both user_transactions and
crypto_transactions for the full picture.

The first tells us the fees and the second tells us the address and
tx_id.

After querying them, correlating them by matching them via timestamp,
type, asset is also done.
LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this issue Dec 13, 2023
Fix rotki#1863

Achieve that by querying an extra endpoint for bitstamp
deposit/withdrawals. The crypto_transactions.

Unfortunately we need to query both user_transactions and
crypto_transactions for the full picture.

The first tells us the fees and the second tells us the address and
tx_id.

After querying them, correlating them by matching them via timestamp,
type, asset is also done.
LefterisJP added a commit that referenced this issue Dec 13, 2023
Fix #1863

Achieve that by querying an extra endpoint for bitstamp
deposit/withdrawals. The crypto_transactions.

Unfortunately we need to query both user_transactions and
crypto_transactions for the full picture.

The first tells us the fees and the second tells us the address and
tx_id.

After querying them, correlating them by matching them via timestamp,
type, asset is also done.
@LefterisJP
Copy link
Member

Should be fixed by #7096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exchange Issues related to integration with an exchange
Projects
None yet
Development

No branches or pull requests

4 participants