Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETH2 in flight deposits are not shown as balance #1888

Closed
LefterisJP opened this issue Dec 10, 2020 · 0 comments · Fixed by #1890
Closed

ETH2 in flight deposits are not shown as balance #1888

LefterisJP opened this issue Dec 10, 2020 · 0 comments · Fixed by #1890
Milestone
v1.10.0

Comments

@LefterisJP
Copy link
Member

Abstract

If the user has a deposit in flight to the deposit contract it's not shown in his balance at all. We should still count that as ETH deposited in the beacon chain even if it has not been activated yet.

Task

Do it
@LefterisJP LefterisJP added this to the v1.10.0 milestone Dec 10, 2020
LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this issue Dec 10, 2020
@LefterisJP
Detect balances of Eth2 deposits that are pending
2bb9271 
Fix rotki#1888

Detect balances of Eth2 deposits that are pending and the validator is
not yet active in the beacon chain
@LefterisJP LefterisJP mentioned this issue Dec 10, 2020
Merged
@LefterisJP LefterisJP mentioned this issue Dec 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.10.0
1 participant
@LefterisJP