Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new token ASSY #2273

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Add new token ASSY #2273

merged 1 commit into from
Feb 3, 2021

Conversation

CPatchane
Copy link
Contributor

@CPatchane CPatchane commented Feb 2, 2021 •
edited
Loading

LefterisJP
LefterisJP approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@LefterisJP LefterisJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Ced. Thanks a lot!

@LefterisJP
Copy link
Member

e2e failure is due to the usual flakiness that kelsos is gonna handle

backend is due to infura timeout on uniswap trades test. We should try to do something about that ... not the first time we see it.

2021-02-03T00:04:09.9099452Z [02/02/2021 23:55:33 UTC] WARNING rotkehlchen.chain.ethereum.manager: Failed to query own node for <bound method EthereumManager._call_contract of <rotkehlchen.chain.ethereum.manager.EthereumManager object at 0x7f0d56640950>> due to Error doing call on contract 0x06FE76B2f432fdfEcAEf1a7d4f6C3d41B5861672: {'code': -32000, 'message': 'execution aborted (timeout = 5s)'}

@LefterisJP LefterisJP merged commit c96d6ce into rotki:develop Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LefterisJP LefterisJP LefterisJP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CPatchane @LefterisJP