Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors retrieving KuCoin trades #2398

Closed
bgibbsjr opened this issue Feb 17, 2021 · 2 comments · Fixed by #2406
Closed

Errors retrieving KuCoin trades #2398

bgibbsjr opened this issue Feb 17, 2021 · 2 comments · Fixed by #2406
Labels
bug Something isn't working
Milestone
v1.14.2

Comments

@bgibbsjr
Copy link

bgibbsjr commented Feb 17, 2021 •
edited by LefterisJP

Problem Definition

Received the following errors, when trades were being retrieved from the KuCoin exchange:

"Backend messages"
Query history of kucoin exchange died with exception: Expected either FVal or int.. Check the logs for more details

"Trades for KuCoin"
Failed query for KuCoin: Error: The backend query task died unexpectedly: Expected either FVal or int.

image

Steps:

  1. Added KuCoin exchange.
  2. Switched to dashboard and saw KuCoin balances.
  3. Clicked History -> Trades and the process began to retrieve the trades.
  4. The "Backend messages" error appeared in the Notifications, after about a minute.
  5. The "Trades for KuCoin" error appeared, after a couple of minutes.
  6. Closed the application and restarted it, with Debug logging.
  7. Clicked History -> Trades again and received the same errors.

Logs

Log files attached (but deleted from lefteris)

  1. rotkehlchen.log
  2. rotki_electron.log

System Description

Operating system: Windows 10 64-bit
Rotki version: 1.14.0
@LefterisJP
Copy link
Member

LefterisJP commented Feb 17, 2021 •
edited

Hey @bgibbsjr thanksa lot for the report. I am deleting the logs from the issue as they may contain sensitive info.

I can see where the problem is from the logs.

For some reason Kucoin for your account sends some data differently than we expect and does not agree with their api docs. Will analyze the problem and figure out a solution. It will be included in the next release.

@LefterisJP LefterisJP added the bug Something isn't working label Feb 17, 2021
@LefterisJP LefterisJP added this to the v1.15.0 milestone Feb 17, 2021
@bgibbsjr
Copy link
Author

Thank-you!

@LefterisJP LefterisJP modified the milestones: v1.15.0, v1.14.2 Feb 18, 2021
LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this issue Feb 18, 2021
@LefterisJP
Fix Kucoin trade parsing for some really specific edge cases
e6f06c7 
In some very specific edge cases Kucoin was returning a string id
which was parseable as a number and we were returning it as an fval
due to rlk_decode_value.

We are now ignoring the relevant kucoin attribute keys and also force
string there so this should not happen again.

Fix rotki#2398
This was referenced Feb 18, 2021
Merged
Closed
LefterisJP added a commit that referenced this issue Feb 19, 2021
@LefterisJP
Fix Kucoin trade parsing for some really specific edge cases
471fbb9 
In some very specific edge cases Kucoin was returning a string id
which was parseable as a number and we were returning it as an fval
due to rlk_decode_value.

We are now ignoring the relevant kucoin attribute keys and also force
string there so this should not happen again.

Fix #2398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.14.2
Development

Successfully merging a pull request may close this issue.

Fix Kucoin trade history parsing edge case LefterisJP/rotkehlchen
2 participants
@bgibbsjr @LefterisJP