Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better integrate the module support with account addition #2778

Closed
kelsos opened this issue Apr 23, 2021 · 5 comments · Fixed by #3127
Closed

Better integrate the module support with account addition #2778

kelsos opened this issue Apr 23, 2021 · 5 comments · Fixed by #3127
Assignees
Labels
Milestone

Comments

@kelsos
Copy link
Member

kelsos commented Apr 23, 2021

Problem Definition

Find a way to better integrate the module filtering for addresses with the account addition.
The scenario is when a user has already a few selected addresses for example on Uniswap and they add a new account. This account will not be queried for Uniswap trades and there is no clear indication anywhere that
the user has to manually go and add allow the account querying for uniswap trades.

Find a way to better integrate the account addition with allowing the addition of the address queried addresses for a module assuming that the module is not whitelisting all the addresses.

Task

TBD

@kelsos kelsos self-assigned this Apr 23, 2021
@kelsos kelsos added this to the v1.18.0 milestone Apr 23, 2021
@kelsos
Copy link
Member Author

kelsos commented Apr 23, 2021

@LefterisJP if you have any ideas in regards to that please fill in

@LefterisJP
Copy link
Member

I think that we need to have some kind of list of addresses that are queried at each protocol's UI page.

It does not need to show all, as it may be big. Can be truncated and pressing it would take you to the actual settings page to edit it.

I guess the problem we solve here is to always remind the user that a subset of addresses (unless it's the default of all) is queried so that they may not blame missing data on rotki.

@yabirgb
Copy link
Member

yabirgb commented Apr 23, 2021

What I would expect as user will be something like in this image where by default my selected modules are activated in this screen for the account and if I want I can edit this list. Adding this option here makes clear that this account will have the selected modules. Also if the default behavior by default is all deactivated this list can start being empty and before clicking save some modules can be selected
proposal

@LefterisJP
Copy link
Member

but this would only be for adding new accounts. What about your already existing accounts?

@kelsos
Copy link
Member Author

kelsos commented Apr 25, 2021

but this would only be for adding new accounts. What about your already existing accounts?

We also have the issue about showing the queried accounts that you mentioned above, but these are two different things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants