Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Javascript front-end code with Typescript #40

Closed
LefterisJP opened this issue Apr 27, 2018 · 39 comments
Closed

Replace Javascript front-end code with Typescript #40

LefterisJP opened this issue Apr 27, 2018 · 39 comments
Labels
bounty worthy Issues that could be worthy of a bounty help wanted Extra attention is needed

Comments

@LefterisJP
Copy link
Member

The front-end of the electron app is written in vanilla javascript and jquery.

It's rather ugly but it works. Many people advised that rewritting in Typescript will help improve it and make it more maintainable.
@LefterisJP LefterisJP added the help wanted Extra attention is needed label Apr 27, 2018
@chatzipan
Copy link

is anyone working on this? otherwise i would like to start

@LefterisJP
Copy link
Member Author

Hello @chatzipan I don't think anyone else is working on this. That would be great. I also replied on twitter.

@LefterisJP LefterisJP added the bounty worthy Issues that could be worthy of a bounty label Jun 22, 2018
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to it.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 3 weeks, 1 day from now. Please review their questions below:

  1. iamonuwa has started work.
  • Q: No questions for now.

@Thoughtscript
Copy link

Hi @LefterisJP - is this issue still available? Thanks!

@LefterisJP
Copy link
Member Author

@Thoughtscript It seems that @iamonouwa has started work on it according to gitcoin bot

@nemani
Copy link

nemani commented Jul 8, 2018

There seems to be an issue here. The gitcoin page does not show @iamonuwa working on it. Also from his gitcoin profile it seems that he is working on many other issues.
@iamonuwa did you "stop" working on this? Or is it a gitcoin bug?

@eayoungs
Copy link

Hey, I'm getting some errors on installing packages with NPM that seem to indicate that Xcode CLI tools is not enough, that full Xcode must be installed. Can anyone verify this? @LefterisJP ?
Thx!

@LefterisJP
Copy link
Member Author

The OSX installation by source guide is here. I don't use OSX myself so I can't help much. I have tried it only 2 times in some old OSX machines and it worked fine using that guide.

@gitcoinbot
Copy link

@eayoungs Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@eayoungs
Copy link

@gitcoinbot My WIP PIR is #107

@LefterisJP
Copy link
Member Author

@eayoungs You made a PR that just renames javascript files to typescript and fails the tests 11 days ago. If you don't want to continue or don't know how to do so please close the PR and let someone who can do this faster and do this effectively.

@iamonuwa
Copy link

@eayoungs are you still working on this task? If no, I've already done some of the job. I would love to pick it and finish it up.

@owocki
Copy link

owocki commented Jul 23, 2018

per request from the rotkehlchen team; i have removed all contributors to this bounty and set the bounty as 'approval required'.

to future bounty hunters; please only apply if you are serious about turning around the bounty

@gitcoinbot
Copy link

@StevenJNPearce Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@StevenJNPearce
Copy link

StevenJNPearce commented Jul 27, 2018 •
edited

Not sure why @gitcoinbot is complaining, only got the accepted email yesterday. Anyway, making good progress, it's a little tedious, 3/12 files completed so far.

@owocki
Copy link

owocki commented Jul 27, 2018

Not sure why @gitcoinbot is complaining, only the accepted email yesterday. Anyway, making good progress, it's a little tedious, 3/12 files completed so far.

ahh good point! well have to update gitcoinbot to comment after the 'acceptance' time, not the application time. thanks for the feedback

@gitcoinbot
Copy link

@mikestonecodes Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@vs77bb
Copy link

vs77bb commented Jul 30, 2018

Thanks for the feedback @StevenJNPearce! This one is yours to run with, excited to see what you come up with here.

@owocki owocki mentioned this issue Jul 30, 2018
Merged
3 tasks
@StevenJNPearce StevenJNPearce mentioned this issue Aug 1, 2018
Closed
@gitcoinbot
Copy link

@StevenJNPearce Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@StevenJNPearce Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@StevenJNPearce due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@frankchen07
Copy link

@StevenJNPearce - snoozed Gitcoin bot - looks like progress is being made on the PR! 👍

@gitcoinbot
Copy link

gitcoinbot commented Sep 7, 2018 •
edited

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 1 month, 1 week ago.
Please review their action plans below:

  1. kelsos has been approved to start work.

    I will start a clean from scratch conversion. I hope to also use some kind of framework or templates. I will discuss it with you after doing some research.

Learn more on the Gitcoin Issue Details page.

  1. websoftwares has applied to start work (Funders only: approve worker | reject worker).

    I would like to start work on this as I have a lot of experience with refactoring projects, i propose to not do this with a big bang approach and gradually refactor peace by peace to typeScript or maybe ECMAScript 6+ would be an easier path and save time but not quality feel free to contact me for an in depth discussion.

Learn more on the Gitcoin Issue Details page.

@LefterisJP
Copy link
Member Author

@vs77bb As it seems that @StevenJNPearce has stopped work on this I would like to approve @kelsos to give it a try

@vs77bb
Copy link

vs77bb commented Sep 10, 2018

@kelsos You've been approved here! Please update us with a WIP PR when you have the chance 👍

@kelsos kelsos mentioned this issue Sep 10, 2018
Merged
@kelsos
Copy link
Member

kelsos commented Sep 10, 2018

@vs77bb done :)

@LefterisJP
Copy link
Member Author

@vs77bb This bounty has been succesfully completed by @kelsos

@LefterisJP
Copy link
Member Author

@vs77bb There has been no update from gitcoin neither for this bounty which @kelsos completed and has not received yet nor for #41 (comment) which he wants to work on. For over a month now. Is anything wrong?

@frankchen07
Copy link

@LefterisJP - @vs77bb has been traveling as of late, which is why he might be slow to respond. Let me reach out to him personally :)

@LefterisJP
Copy link
Member Author

@frankchen07 thank you that would be great as we are kind of stuck here.

@gitcoinbot
Copy link

⚡️ A tip worth 200.00000 DAI (200.0 USD @ $1.0/DAI) has been granted to @kelsos for this issue from @vs77bb. ⚡️

Nice work @kelsos! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

1 similar comment
@gitcoinbot
Copy link

⚡️ A tip worth 200.00000 DAI (200.0 USD @ $1.0/DAI) has been granted to @kelsos for this issue from @vs77bb. ⚡️

Nice work @kelsos! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

@vs77bb
Copy link

vs77bb commented Oct 25, 2018

Hi @LefterisJP sorry this one took so long -- @kelsos didn't 'Submit Work' on his side, so we had to use the Advanced Payout feature to pay out. This was complicated by the fact that we took 'Advanced Payout' down on our side for a few weeks to debug a few things.

Also commented on #41 -- he should be good to go there now, as well 👍

@kelsos
Copy link
Member

kelsos commented Oct 25, 2018

@vs77bb I was not sure how this works, sorry. So I have to submit work on the issue. Also I have no account with any eth, Would this be a valid reason to request some from the faucet to submit the work?.

Furthermore it seems that the tip was send twice. Could you cancel one of two?

@owocki
Copy link

owocki commented Nov 3, 2018

yes, please request a faucet dispursement for this

@rmshea
Copy link

rmshea commented Dec 10, 2018

hey @kelsos, if you need help with this, let me know!

@rmshea
Copy link

rmshea commented Jan 30, 2019

@kelsos any updates?

@LefterisJP
Copy link
Member Author

This is finished. @ryan-shea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty worthy Issues that could be worthy of a bounty help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests