Write the basic front-end UI tests

[LefterisJP]

At the moment there is only 2 UI tests using spectron and mocha. They act as a simple smoke test.

Need a lot more tests covering the basic usage scenarios of the application via the UI. Write tests for:

• Going to the user settings, adding an ethereum account and looking at its balance
• Adding a token and seeing that tokens get updated
• Adding a bitcoin account and seeing that the balance is there
• Adding a fiat balance and see that it's properly updated
• Add an exchange and see that the API key is succesfully accepted
• Change the currency to EUR and that the currency changes everywhere in the UI
• Change each one of the settings and see that the change has been applied

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

This issue now has a funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to it.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $29,374.53 more funded OSS Work available on the Gitcoin Issue Explorer

[kaviyarasu7]

@LefterisJP - any UI automation framework preferences do you have for this?

[LefterisJP]

Hello @kaviyarasu7. Yes something is already being used. It's spectron and mocha.

[gitcoinbot]

@tungsheng Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• warning (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[vs77bb]

Hi @tungsheng do you have any updates on your progress here? Hope you are doing well 🙂

[tungsheng]

Hello @vs77bb , thank you for asking!! I tried to set up local environment in docker. But keep running into this error when I tried to start the app:

0 info it worked if it ends with ok
1 verbose cli [ '/root/.nvm/versions/node/v8.2.0/bin/node',
1 verbose cli   '/root/.nvm/versions/node/v8.2.0/bin/npm',
1 verbose cli   'start' ]
2 info using npm@5.3.0
3 info using node@v8.2.0
4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle rotkehlchen@0.3.1~prestart: rotkehlchen@0.3.1
6 info lifecycle rotkehlchen@0.3.1~start: rotkehlchen@0.3.1
7 verbose lifecycle rotkehlchen@0.3.1~start: unsafe-perm in lifecycle true
8 verbose lifecycle rotkehlchen@0.3.1~start: PATH: /root/.nvm/versions/node/v8.2.0/lib/node_modules/npm/bin/node-gyp-bin:/rotkehlchen/node_modules/.bin:/rotkehlchen/virtualenvs/rotkehlchen/bin:/root/.nvm/versions/node/v8.2.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
9 verbose lifecycle rotkehlchen@0.3.1~start: CWD: /rotkehlchen
10 silly lifecycle rotkehlchen@0.3.1~start: Args: [ '-c', 'electron .' ]
11 silly lifecycle rotkehlchen@0.3.1~start: Returned: code: 1  signal: null
12 info lifecycle rotkehlchen@0.3.1~start: Failed to exec start script
13 verbose stack Error: rotkehlchen@0.3.1 start: `electron .`
13 verbose stack Exit status 1
13 verbose stack     at EventEmitter.<anonymous> (/root/.nvm/versions/node/v8.2.0/lib/node_modules/npm/lib/utils/lifecycle.js:289:16)
13 verbose stack     at emitTwo (events.js:125:13)
13 verbose stack     at EventEmitter.emit (events.js:213:7)
13 verbose stack     at ChildProcess.<anonymous> (/root/.nvm/versions/node/v8.2.0/lib/node_modules/npm/lib/utils/spawn.js:40:14)
13 verbose stack     at emitTwo (events.js:125:13)
13 verbose stack     at ChildProcess.emit (events.js:213:7)
13 verbose stack     at maybeClose (internal/child_process.js:921:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
14 verbose pkgid rotkehlchen@0.3.1
15 verbose cwd /rotkehlchen
16 verbose Linux 4.9.93-linuxkit-aufs
17 verbose argv "/root/.nvm/versions/node/v8.2.0/bin/node" "/root/.nvm/versions/node/v8.2.0/bin/npm" "start"
18 verbose node v8.2.0
19 verbose npm  v5.3.0
20 error code ELIFECYCLE
21 error errno 1
22 error rotkehlchen@0.3.1 start: `electron .`
22 error Exit status 1
23 error Failed at the rotkehlchen@0.3.1 start script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]

Still tring to figure it out. Any suggestion about working electron app in docker?
I am using Mac, OSX 10.13.
Docker version: 18.05.0-ce-mac67

[LefterisJP]

@tungsheng I have never tried to do this via docker. Why docker? This is an app with a UI. The supported options for installation are here: https://github.com/rotkehlchenio/rotkehlchen#installation.

[Thoughtscript]

Hi @LefterisJP - is this issue still available? Thanks!

[tungsheng]

@LefterisJP Initially, I want to set up isolated dev environment. but ended up giving up. Now I can successfully install and start the app. However, another issue i ran into is python backend crashed error:

child process success on port 4242
CREATED PYPROCESS
subprocess killed with signal null and code 1

did I miss anything during the install process?
(the error alert told me to find rotkehlchen.log, but i can't find it in the folder..)

[LefterisJP]

@tungsheng Did you run it in a virtual environment? Did you try to run the python backend on its own python -m rotkehlchen and see what happens?

If you are having installation issues perhaps you can take them in another issue and let's not clutter this one?

[tungsheng]

@LefterisJP Sure, I apologize for the delay I've caused! I will keep trying the installation. Hope I am able to contribute in another issue!

[pmespresso]

Hi, somehow I am logged in already on the first launch and the icon in top right just remains spinning. When I try to log out it takes me to a blank page. Is this test meant to be passing? I'm using anaconda and my $HOME/.rotkehlchen directory is clean. @LefterisJP Thanks!

[LefterisJP]

Type ctrl+shift+I to get the chrome console and check what's wrong. There is an error if you don't get the login prompt.

Incidentally this is the one thing that's already tested in the tests in both Macos and Linux so it works if properly installed:

[pmespresso]

/Developer/rotkehlchen/node_modules/zmq/build/Release/zmq.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 53. This version of Node.js requires
NODE_MODULE_VERSION 57. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`)

I've so far tried just deleting node_modules and reinstalling, as well as PYTHON=/usr/bin/python2.7 ./node_modules/.bin/electron-rebuild both to no avail though :(

[LefterisJP]

Are you on OSX @yjkimjunior?

As per also the build by source docs found here, try:

rm -rf ./node_modules
npm config set python python2.7
npm install
PYTHON=/usr/bin/python2.7 ./node_modules/.bin/electron-rebuild

[gitcoinbot]

@eayoungs Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• warning (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[vs77bb]

Hi @eayoungs - any update here on your side?

[gitcoinbot]

@eayoungs Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• warning (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@eayoungs Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• warning (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[owocki]

per request from the rotkehlchen team; i have removed all contributors to this bounty and set the bounty as 'approval required'.

to future bounty hunters; please only apply if you are serious about turning around the bounty

[gitcoinbot]

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• warning (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[LefterisJP]

@gitcoinbot @vs77bb @owocki I would like to approve iamonuwa to start work on this but gitcoin interface does not let me. Can you please change the permissions so that I can approve work myself?

[gitcoinbot]

@auroq Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• warning (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• warning (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[iamonuwa]

@gitcoinbot am almost done

[auroq]

Sounds like @iamonuwa has this handled. Since I was second dibs, I'll stop work so I don't keep getting pinged by @gitcoinbot. I'll watch for similar future bounties, though.

[vs77bb]

@auroq Sounds good! Thanks for your interest here and definitely do take a peek, more to come on the explorer 🙂

[Thoughtscript]

Hi! Just checking to see if there's any work on this that still needs doing! Thanks!

[gitcoinbot]

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• warning (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[iamonuwa]

@gitcoinbot @Thoughtscript @LefterisJP sorry I went MIA. I took ill last Friday couldn't push my commit. I'll do that now. Currently, Work in Progress

[vs77bb]

Hi @iamonuwa where are we with this bounty? Looks like it returned to an 'Open' status on Gitcoin

[LefterisJP]

@iamonuwa Your PR(#118) has no activity for 18 days. If you can't finish it please let other people work on this.

[binarybaba]

@LefterisJP, new to python. im more into js. I forked the repo but it crashed and I cant find a rotkehlchen.log. Am i missing something?
OSX High Sierra 10.13.2
Node 10.5.0
Python 3.7.0

[LefterisJP]

@binarybaba Hello! Please read the documentation on how to build from source. If you have problems open a separate issue. I would like to keep the issues on-topic.

(most probably you never prepared the python backend)

[binarybaba]

I thought the setup script would take care of that. Sorry. I'll go through the stuff. I was hoping to pick this issue up. If I find an issue in the setup will open another issue. Thanks!

[LefterisJP]

Hello @mykeels. Very good. I will ask @vs77bb to approve you. Your commit of the first test seems fine from a first look: mykeels@c3305b4

[binarybaba]

Guess I'll step back now.

[mykeels]

@LefterisJP I just saw my name marked as "started work" on the gitcoin page for this issue. I understand this to mean I have been approved and can continue work on this task. Is my assumption correct?

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work for 200.0 DAI (200.0 USD @ $1.0/DAI) has been submitted by:

1. @mykeels

@vs77bb please take a look at the submitted work:

• PR by @mykeels

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $20,653.87 more funded OSS Work available on the Gitcoin Issue Explorer

[rmshea]

Hey @mykeels, wanted to check in on this bounty and see what the latest is. @LefterisJP, is the bounty completed? Thanks :)

[LefterisJP]

@vs77bb Can you please remove @mykeels from the bounty. He has done some work but has not finished it and we need this done asap.

@kelsos who is also doing #149 and has almost finished it has expressed interest to finish the tests too as he has become really accustomed with the code.

So @vs77bb Can you please assign the bounty to @kelsos?

[PixelantDesign]

@kelsos could you click start work on Gitcoin if you'll be completing this issue?

[kelsos]

@PixelantDesign it seems that it is still assigned to the previous developer that was working on the issue so I am not able to press start work.

[vs77bb]

@kelsos please try again now!

[kelsos]

@vs77bb unfortunately I still can't see the start work button on the page.

[LefterisJP]

@vs77bb The bounty should go to @kelsos. He has successfully finished the task.

[gitcoinbot]

Issue Status: 1. Open 2. Cancelled

---

The funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter

• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $85,950.79 more funded OSS Work available on the Gitcoin Issue Explorer