Support deposit/withdrawal queries for binance.

[LefterisJP]

Problem Definition

Rotkehlchen so far did not support inclusion of deposit/withdrawal queries for Binance since there is no such endpoint in their API docs: https://github.com/binance-exchange/binance-official-api-docs/blob/master/rest-api.md

Task

After a twitter rant about absence of API endpoint for deposits/withdrawal queries for Binance it seems that there actually is an endpoint but in a different document:

https://github.com/binance-exchange/binance-official-api-docs/blob/master/wapi-api.md

No idea why the separate document and no reference from one to another .... but this seems to enable us to query deposits/withdrawals for binance too. So the task for this issue is:

• Support deposits/withdrawals queries for binance and take them into account in the profit/loss calculation.
• Write tests for:
  • The happy case of a few deposit/withdrawal queries
  • The unhappy case of unexpected data returned either from a deposit or a withdrawal query.

An important note for implementation here is that according to this twitter thread only 3 months are returned from those API endpoint at a time so may need to perform a pagination of 3 months from the time of the first trade or creation of the account.

Can't confirm it ^. With a simple query of all deposits I got all deposits I ever did in Binance 1.5 year ago.