Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Asset icon issues and inconsistant #465

Closed
chevdor opened this issue Aug 13, 2019 · 5 comments
Closed

UI: Asset icon issues and inconsistant #465

chevdor opened this issue Aug 13, 2019 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@chevdor
Copy link
Contributor

chevdor commented Aug 13, 2019

Problem Definition

Somehow, the DAI icon does not make it :)
image

You can also notice inconsistency in the display of the assets and balances. ETH is displayed on the right while other assets' names are shown below the icon.

@LefterisJP
Copy link
Member

There is two issues here. I guess one is the display of asset name + centering which I guess is a CSS issue right @kelsos ?

The other is probably a need to update the crypto icons package.

@LefterisJP LefterisJP added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 13, 2019
@kelsos
Copy link
Member

kelsos commented Aug 13, 2019

@LefterisJP Probably a css issue yes, and DAI should be available in the latest version of the crypto icons package. I am using it in the rewrite and the DAI icon is there.

LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this issue Aug 18, 2019
LefterisJP added a commit that referenced this issue Aug 18, 2019
@LefterisJP
Copy link
Member

@kelsos With the different way the owned tokens are displayed to the user in v1.1.0 this issue is essentially handled, right?

@kelsos
Copy link
Member

kelsos commented Jan 2, 2020

Yes since we changed the way we handle the owned tokens this is not a valid issue anymore.

@LefterisJP
Copy link
Member

Well I would say it is a valid issue but fixed 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants