Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import data from Cointracking: Support Staking #6274

Closed
PabloCastellano opened this issue Jun 18, 2023 · 4 comments
Closed

Import data from Cointracking: Support Staking #6274

PabloCastellano opened this issue Jun 18, 2023 · 4 comments
Labels
easy Easy issue. But maybe not good first. Fast if you are a bit familiar. file import Importing data from a specific service given a file (e.g. CSV) good first issue Good for newcomers

Comments

@PabloCastellano
Copy link
Contributor

Problem Definition

Importing data from a Cointracking CSV csv file with the column Type='Staking' will fail in rotki.

Example file:

"Type","Buy","Cur.","Sell","Cur.","Fee","Cur.","Exchange","Group","Comment","Date"
"Staking","1.00000000","AXS","","","","","Binance","","","05.01.2022 12:38:00"
"Staking","2.12000000","ETH","","","","","Binance","","","08.02.2022 11:29:00"

Logs

[18/06/2023 17:00:58 CEST] WARNING rotkehlchen.user_messages Greenlet-6: Unknown entrype type "Staking" encountered during cointracking data import. Ignoring entry
[18/06/2023 17:00:58 CEST] WARNING rotkehlchen.user_messages Greenlet-6: Unknown entrype type "Staking" encountered during cointracking data import. Ignoring entry

System Description

Operating system: Linux Mint
Rotki version: v1.28.0

@LefterisJP LefterisJP added good first issue Good for newcomers easy Easy issue. But maybe not good first. Fast if you are a bit familiar. file import Importing data from a specific service given a file (e.g. CSV) labels Jun 18, 2023
@palrohitg
Copy link

Hey @PabloCastellano @PabloCastellano : As I'm going through the codebase to understand a bit, was able to figure out that if CSV file containing Type as "Staking" we have an exception block in cointracking.py . It would be great if you can a little more details, basically need to pass this condition or perform some action on staking type.

@LefterisJP
Copy link
Member

Hey @PabloCastellano @PabloCastellano : As I'm going through the codebase to understand a bit, was able to figure out that if CSV file containing Type as "Staking" we have an exception block in cointracking.py . It would be great if you can a little more details, basically need to pass this condition or perform some action on staking type.

The problem Pablo states is that rotki does not seem to understand lines that have "Staking" as their type when importing something from Cointracking.

So these should not be skipped but instead of skipped have a proper staking HistoryEvent generated and added to rotki.

@Jaspreet-singh-1032
Copy link
Contributor

Hi @palrohitg, Just wants to know if you are still working on this issue. If not then I would like to give it a try.

@palrohitg
Copy link

palrohitg commented Jun 27, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Easy issue. But maybe not good first. Fast if you are a bit familiar. file import Importing data from a specific service given a file (e.g. CSV) good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants