Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate all user input for EIP55 compliance #69

Closed
LefterisJP opened this issue May 29, 2018 · 1 comment
Closed

Validate all user input for EIP55 compliance #69

LefterisJP opened this issue May 29, 2018 · 1 comment

Comments

@LefterisJP
Copy link
Member

At the moment web3.py requires EIP55 compliance. So before forwarding any hex-addresses to web3.py the to_checksum_address() function is used. But this is missing the point, as this is something that the user should provide checksummed.

  • Make sure all places where the user provides hex address check if it's EIP55 compliant with is_checksum_address().
  • Remove all to_checksum_address and see if anything else ends up in the web3.py part of the code without a checksum. If so it means that there is more input that has not been sanitized.
@LefterisJP
Copy link
Member Author

This should be done by forcing the addition of blockchain accounts through to_checksum_address.

LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this issue Jul 28, 2019
@LefterisJP
Make sure eth addresses are checksummed at input
e14a326 
Should fix rotki#69. Essentially makes sure ethereum addresses are
checksummed for both addition and removal to the application.
@koeppelmann koeppelmann mentioned this issue Apr 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LefterisJP