Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding an EOA address that has no activity apart from withdrawals/blocks fails. #7123

Closed
LefterisJP opened this issue Dec 18, 2023 · 1 comment
Closed

Adding an EOA address that has no activity apart from withdrawals/blocks fails. #7123

LefterisJP opened this issue Dec 18, 2023 · 1 comment
Assignees
@OjusWiZard
Labels
bug Something isn't working
Milestone
1.31.2

Comments

@LefterisJP
Copy link
Member

LefterisJP commented Dec 18, 2023 •
edited

Problem Definition

If you try to add an EOA address that has no other activity apart from eth2 withdrawals or non-mev block productions in rotki it fails. The reason is that no transactions/erc20 transfers etc. happened and we don't query for withdrawals or blocks and as such for rotki it seems as if the address has had no activity.

An example address is: https://etherscan.io/address/0x3c69bc9b9681683890ad82953fe67d13cd91d5ee

Task

When adding/detecting activity for an address, if it's mainnet also check if it has any ETH balance.
@LefterisJP LefterisJP added the bug Something isn't working label Dec 18, 2023
@LefterisJP LefterisJP added this to the 1.31.2 milestone Dec 18, 2023
@LefterisJP LefterisJP changed the title Adding an address that has no activity apart from withdrawals/blocks fails. Adding an EOA address that has no activity apart from withdrawals/blocks fails. Dec 18, 2023
@OjusWiZard OjusWiZard self-assigned this Dec 19, 2023
OjusWiZard added a commit to OjusWiZard/rotki that referenced this issue Dec 19, 2023
@OjusWiZard
fix (rotki#7123): check for eth balance in has_activity
56ced8f 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
OjusWiZard added a commit to OjusWiZard/rotki that referenced this issue Dec 19, 2023
@OjusWiZard
fix (rotki#7123): check for eth balance in has_activity
0a72d51 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard OjusWiZard mentioned this issue Dec 19, 2023
Merged
3 tasks
OjusWiZard added a commit to OjusWiZard/rotki that referenced this issue Dec 19, 2023
@OjusWiZard
fix (rotki#7123): check for eth balance in has_activity
b565765 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
OjusWiZard added a commit to OjusWiZard/rotki that referenced this issue Dec 19, 2023
@OjusWiZard
fix (rotki#7123): check for eth balance in has_activity
d1a94b7 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
OjusWiZard added a commit to OjusWiZard/rotki that referenced this issue Dec 20, 2023
@OjusWiZard
fix (rotki#7123): check for eth balance in has_activity
535ef92 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
OjusWiZard added a commit to OjusWiZard/rotki that referenced this issue Dec 20, 2023
@OjusWiZard
fix (rotki#7123): check for eth balance in has_activity
5faab8b 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
LefterisJP pushed a commit that referenced this issue Dec 20, 2023
@OjusWiZard @LefterisJP
fix (#7123): check for eth balance in has_activity
9415e1c 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@LefterisJP
Copy link
Member Author

should be fixed by #7136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OjusWiZard OjusWiZard

Labels
bug Something isn't working
Projects
None yet
Milestone
1.31.2
Development

No branches or pull requests
2 participants
@LefterisJP @OjusWiZard