Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV export should also contain human readable addresses from the users + global addressbook #7176

Closed
LefterisJP opened this issue Dec 26, 2023 · 2 comments · Fixed by #7235
Closed
Assignees
Labels
accounting Issues that affect the acounting and tax report part of the app
Milestone

Comments

@LefterisJP
Copy link
Member

LefterisJP commented Dec 26, 2023

Abstract

The notes for transaction events of the PnL export are exported raw. In the UI all hexadecimal addresses are checked against addressbook and replaced if existing. But the CSV export does not do this.

It has been requested we do this as it is a value add for the user. cc @Buttaa

Task

  • If the event in the CSV export has any addresses in the notes add the label next to it in brackets. For example <address> [label] This will require some text processing with regexes, similar to what the frontend does on top of the notes.
@LefterisJP LefterisJP added the accounting Issues that affect the acounting and tax report part of the app label Dec 26, 2023
@LefterisJP LefterisJP added this to the 1.32.0 milestone Dec 26, 2023
@Buttaa
Copy link
Contributor

Buttaa commented Dec 26, 2023

@LefterisJP i would not replace it but add it next to it, e.g .... <address> [label]...

@LefterisJP
Copy link
Member Author

@LefterisJP i would not replace it but add it next to it, e.g .... <address> [label]...

Can do. Sure. In the UI it's replaced but can also hover over it and see addy. In a CSV export your suggestion is better.

@OjusWiZard OjusWiZard self-assigned this Jan 2, 2024
OjusWiZard added a commit to OjusWiZard/rotki that referenced this issue Jan 5, 2024
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
OjusWiZard added a commit to OjusWiZard/rotki that referenced this issue Jan 5, 2024
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
OjusWiZard added a commit to OjusWiZard/rotki that referenced this issue Jan 8, 2024
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
OjusWiZard added a commit to OjusWiZard/rotki that referenced this issue Jan 8, 2024
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
OjusWiZard added a commit to OjusWiZard/rotki that referenced this issue Jan 8, 2024
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
OjusWiZard added a commit to OjusWiZard/rotki that referenced this issue Jan 8, 2024
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
LefterisJP pushed a commit that referenced this issue Jan 8, 2024
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accounting Issues that affect the acounting and tax report part of the app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants