Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eth staking execution rewards are doubled in 1.32.0 #7497

Closed
LefterisJP opened this issue Feb 17, 2024 · 1 comment
Closed

Eth staking execution rewards are doubled in 1.32.0 #7497

LefterisJP opened this issue Feb 17, 2024 · 1 comment
Assignees
@LefterisJP
Labels
bug Something isn't working
Milestone
1.32.1

Comments

@LefterisJP
Copy link
Member

Problem Definition

The execution rewards in eth staking view after the 1.32.0 changes are 2 times the amount they should be.

Task

Fix it.
@LefterisJP LefterisJP added the bug Something isn't working label Feb 17, 2024
@LefterisJP LefterisJP added this to the 1.32.1 milestone Feb 17, 2024
@LefterisJP LefterisJP self-assigned this Feb 17, 2024
@LefterisJP LefterisJP changed the title Execution rewards are doubled in 1.32.0 Eth staking execution rewards are doubled in 1.32.0 Feb 17, 2024
LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this issue Feb 17, 2024
@LefterisJP
Fix incorrect counting of ETH staking execution rewards
8d0cbb7 
Fix rotki#7497

ETH block rewards and MEV rewards should now only be counted if the
recipient address is tracked.

Signed-off-by: Lefteris Karapetsas <lefteris@refu.co>
@LefterisJP LefterisJP mentioned this issue Feb 17, 2024
Merged
LefterisJP added a commit that referenced this issue Feb 17, 2024
@LefterisJP
Fix incorrect counting of ETH staking execution rewards
de1413a 
Fix #7497

ETH block rewards and MEV rewards should now only be counted if the
recipient address is tracked.

Signed-off-by: Lefteris Karapetsas <lefteris@refu.co>
@LefterisJP
Copy link
Member Author

Should be fixed by #7500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LefterisJP LefterisJP

Labels
bug Something isn't working
Projects
None yet
Milestone
1.32.1
Development

No branches or pull requests
1 participant
@LefterisJP