Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes match operator to fix test flakiness #1594

Merged
merged 1 commit into from Oct 15, 2020

Conversation

kelsos
Copy link
Member

@kelsos kelsos commented Oct 15, 2020

It should fix the ui test flakiness due to match also matching any string containing the number

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #1594 into develop will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1594      +/-   ##
===========================================
+ Coverage    70.97%   71.33%   +0.36%     
===========================================
  Files          344      359      +15     
  Lines        16793    19514    +2721     
  Branches      2334     2767     +433     
===========================================
+ Hits         11919    13921    +2002     
- Misses        4307     4877     +570     
- Partials       567      716     +149     
Flag Coverage Δ
#backend 80.89% <ø> (-1.75%) ⬇️
#frontend_integration 51.16% <ø> (-0.03%) ⬇️
#frontend_unit 23.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
frontend/app/src/store/tasks/mutations.ts 94.11% <0.00%> (-5.89%) ⬇️
rotkehlchen/externalapis/etherscan.py 76.08% <0.00%> (-4.35%) ⬇️
rotkehlchen/chain/ethereum/yearn/vaults.py 83.08% <0.00%> (-3.49%) ⬇️
rotkehlchen/accounting/accountant.py 85.04% <0.00%> (-1.87%) ⬇️
rotkehlchen/chain/ethereum/makerdao/vaults.py 87.81% <0.00%> (-1.80%) ⬇️
frontend/app/src/services/task-manager.ts 55.35% <0.00%> (-1.79%) ⬇️
rotkehlchen/premium/sync.py 81.75% <0.00%> (-0.73%) ⬇️
rotkehlchen/rotkehlchen.py 82.74% <0.00%> (ø)
rotkehlchen/exchanges/__init__.py 100.00% <0.00%> (ø)
rotkehlchen/exchanges/binance.py 85.97% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69a2190...88a4e1d. Read the comment docs.

Copy link
Member

@LefterisJP LefterisJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh interesting. I will take your word for it. And approve. Which particular UI tests issue does this close?

@LefterisJP LefterisJP merged commit 12a56cc into rotki:develop Oct 15, 2020
@kelsos kelsos deleted the fix-flaky-test branch October 15, 2020 09:28
@kelsos
Copy link
Member Author

kelsos commented Oct 15, 2020

image

We didn't have an issue for that, but I had a todo long due.
The problem was mostly in the .not.matches where not matches 1.21 for example would fail when the value was 41.21...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants