Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add total earned from liquidations in aave history endpoint #1625

Merged
merged 2 commits into from Oct 24, 2020

Conversation

LefterisJP
Copy link
Member

Plus some misc fixes

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #1625 into develop will decrease coverage by 25.73%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #1625       +/-   ##
============================================
- Coverage    70.66%   44.92%   -25.74%     
============================================
  Files          369      254      -115     
  Lines        20365     5700    -14665     
  Branches      2923      759     -2164     
============================================
- Hits         14391     2561    -11830     
+ Misses        5218     2976     -2242     
+ Partials       756      163      -593     
Flag Coverage Δ
#backend ?
#frontend_integration 49.80% <ø> (-0.15%) ⬇️
#frontend_unit 22.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
frontend/app/src/store/tasks/mutations.ts 94.11% <0.00%> (-5.89%) ⬇️
frontend/app/src/services/rotkehlchen-api.ts 52.72% <0.00%> (-1.82%) ⬇️
frontend/app/src/services/task-manager.ts 55.35% <0.00%> (-1.79%) ⬇️
frontend/app/src/store/balances/actions.ts 43.47% <0.00%> (-0.87%) ⬇️
rotkehlchen/csv_exporter.py
rotkehlchen/api/rest.py
rotkehlchen/utils/hashing.py
rotkehlchen/api/v1/resources.py
rotkehlchen/chain/ethereum/makerdao/common.py
rotkehlchen/crypto.py
... and 103 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c140012...64e426b. Read the comment docs.

@LefterisJP
Copy link
Member Author

I will merge this. The only failure seen is due to 502 from a graph query in compound. This kind of errors seem like a remnant from the outage they had.

@LefterisJP LefterisJP merged commit 4fc3513 into rotki:develop Oct 24, 2020
@LefterisJP LefterisJP deleted the some_fixes branch October 24, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant