Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use blockstream API for native segwit address balance queries #1647

Merged
merged 4 commits into from Oct 29, 2020

Conversation

LefterisJP
Copy link
Member

Fix #1639

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #1647 into develop will decrease coverage by 0.10%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1647      +/-   ##
===========================================
- Coverage    70.18%   70.07%   -0.11%     
===========================================
  Files          376      376              
  Lines        20778    20765      -13     
  Branches      3073     3067       -6     
===========================================
- Hits         14582    14551      -31     
- Misses        5426     5440      +14     
- Partials       770      774       +4     
Flag Coverage Δ
#backend 80.52% <50.00%> (-0.14%) ⬇️
#frontend_integration 48.78% <ø> (-0.03%) ⬇️
#frontend_unit 21.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rotkehlchen/chain/bitcoin/xpub.py 65.45% <ø> (ø)
rotkehlchen/chain/manager.py 85.35% <ø> (+1.14%) ⬆️
rotkehlchen/externalapis/etherscan.py 75.80% <0.00%> (-1.92%) ⬇️
rotkehlchen/chain/bitcoin/__init__.py 66.66% <48.00%> (ø)
rotkehlchen/utils/misc.py 86.11% <100.00%> (-0.56%) ⬇️
rotkehlchen/chain/ethereum/manager.py 86.02% <0.00%> (-4.35%) ⬇️
rotkehlchen/chain/ethereum/makerdao/dsr.py 53.41% <0.00%> (-2.49%) ⬇️
rotkehlchen/premium/sync.py 80.00% <0.00%> (-0.67%) ⬇️
rotkehlchen/premium/premium.py 70.39% <0.00%> (-0.66%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd8ee88...294e4f6. Read the comment docs.

It does not really fix rotki#1649 but this will have to do for now as a
measure to get more information in case it happens again.
@LefterisJP
Copy link
Member Author

Merging this. The only error is on Github actions and it's a timeout on yearn vaults test. Perhaps should increase timeout limits on that test.

@LefterisJP LefterisJP merged commit 2fecf4e into rotki:develop Oct 29, 2020
@LefterisJP LefterisJP deleted the workon_1639 branch October 29, 2020 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blockcypher balance call for bitcoin native segwit addresses covertly failing
1 participant