Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes proper display of accounting settings #2135

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

kelsos
Copy link
Member

@kelsos kelsos commented Jan 19, 2021

Closes #2126

@kelsos kelsos changed the base branch from develop to bugfixes January 19, 2021 09:35
@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #2135 (11426f0) into bugfixes (5d752d1) will decrease coverage by 2.38%.
The diff coverage is 29.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##           bugfixes    #2135      +/-   ##
============================================
- Coverage     45.39%   43.01%   -2.39%     
============================================
  Files           294      301       +7     
  Lines          6965     7748     +783     
  Branches        927     1066     +139     
============================================
+ Hits           3162     3333     +171     
- Misses         3616     4236     +620     
+ Partials        187      179       -8     
Flag Coverage Δ
frontend_integration 48.43% <39.75%> (-2.03%) ⬇️
frontend_unit 21.47% <15.80%> (-0.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
frontend/app/src/ErrorScreen.vue 22.22% <ø> (ø)
frontend/app/src/background.ts 0.00% <0.00%> (ø)
frontend/app/src/components/NavigationMenu.vue 50.00% <ø> (ø)
frontend/app/src/components/OtcForm.vue 76.47% <ø> (-1.48%) ⬇️
frontend/app/src/components/UserDropdown.vue 66.66% <ø> (ø)
...rc/components/account-management/CreateAccount.vue 89.58% <ø> (ø)
...mponents/account-management/PremiumCredentials.vue 55.17% <ø> (ø)
.../components/account-management/PremiumReminder.vue 61.53% <ø> (ø)
...pp/src/components/accounts/AccountBalanceTable.vue 47.31% <0.00%> (ø)
...nd/app/src/components/accounts/AccountBalances.vue 56.41% <ø> (ø)
... and 164 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43db7fc...11426f0. Read the comment docs.

Copy link
Member

@LefterisJP LefterisJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM!

@LefterisJP LefterisJP merged commit a4da26e into rotki:bugfixes Jan 19, 2021
@kelsos kelsos deleted the rotki-2126 branch January 20, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggling gas costs and asset movement fees
2 participants