Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use POST instead of GET for historical asset price endpoint #2250

Merged

Conversation

LefterisJP
Copy link
Member

Reason being the formulation of the query string is hard (we don't
know how to and would need to spend time to look it up) with nested arrays.

Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #2250 (4187f5f) into develop (d90cd47) will increase coverage by 0.66%.
The diff coverage is 61.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2250      +/-   ##
===========================================
+ Coverage    72.72%   73.39%   +0.66%     
===========================================
  Files          380      399      +19     
  Lines        22089    26389    +4300     
  Branches      3256     3989     +733     
===========================================
+ Hits         16065    19368    +3303     
- Misses        5152     5925     +773     
- Partials       872     1096     +224     
Flag Coverage Δ
backend 80.51% <64.70%> (-1.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...p/src/components/dashboard/DashboardAssetTable.vue 80.00% <ø> (ø)
...d/app/src/components/dashboard/OverallBalances.vue 71.87% <ø> (-6.25%) ⬇️
...ntend/app/src/components/display/AmountDisplay.vue 95.45% <ø> (ø)
...rontend/app/src/components/helper/AssetDetails.vue 100.00% <ø> (+25.00%) ⬆️
...p/src/components/settings/AccountAssetBalances.vue 60.00% <ø> (ø)
...tend/app/src/components/settings/AssetBalances.vue 77.77% <0.00%> (ø)
rotkehlchen/csv_exporter.py 74.16% <ø> (ø)
rotkehlchen/icons.py 51.21% <25.00%> (-2.73%) ⬇️
rotkehlchen/api/v1/resources.py 94.15% <100.00%> (ø)
rotkehlchen/constants/timing.py 100.00% <100.00%> (ø)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebce966...9856e40. Read the comment docs.

@LefterisJP LefterisJP changed the base branch from bugfixes to develop February 1, 2021 20:54
Reason being the formulation of the query string is hard (we don't
know how to and would need to spend time to look it up) with nested arrays.
@LefterisJP LefterisJP force-pushed the historical_asset_price_use_post branch from 4187f5f to 9856e40 Compare February 1, 2021 20:59
@LefterisJP
Copy link
Member Author

The backend test was an infura timeout:

2021-02-01T21:28:08.8041729Z WARNING  rotkehlchen.chain.ethereum.manager:manager.py:392 Failed to query own node for <bound method EthereumManager._call_contract of <rotkehlchen.chain.ethereum.manager.EthereumManager object at 0x7f94b2ebe350>> due to Error doing call on contract 0x06FE76B2f432fdfEcAEf1a7d4f6C3d41B5861672: {'code': -32000, 'message': 'execution aborted (timeout = 5s)'}

The e2e is the same flaky as always.

@LefterisJP LefterisJP merged commit 000ee7d into rotki:develop Feb 1, 2021
@LefterisJP LefterisJP deleted the historical_asset_price_use_post branch February 1, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants