-
-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduces autofocus of password when remember user is checked #3068
Conversation
private focusPassword() { | ||
this.$nextTick(() => | ||
setTimeout(() => { | ||
(this.$refs.password as any).$el | ||
.querySelector('input:not([type=hidden])') | ||
.focus(); | ||
}, 100) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a bit more complicated than I expected. I had to go through a couple of so threads.
Codecov Report
@@ Coverage Diff @@
## develop #3068 +/- ##
===========================================
+ Coverage 66.35% 66.42% +0.06%
===========================================
Files 562 563 +1
Lines 36412 36447 +35
Branches 5348 5372 +24
===========================================
+ Hits 24161 24209 +48
+ Misses 10932 10920 -12
+ Partials 1319 1318 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
interesting. |
Ok, it seems that this happens on a fresh start but not when refreshing. |
To test the focus working properly in dev mode you have to comment the dev tools opening. Otherwise it will mess with the focus rotki/frontend/app/src/background.ts Line 109 in 2ce27ea
|
Okey for me it's fine. As I understand this will work correctly on the final release so we can merge it :) |
Closes #2954