Make liquity decoder work with DS Proxies #5791
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #5791 +/- ##
===========================================
- Coverage 70.93% 63.44% -7.50%
===========================================
Files 1146 1146
Lines 80637 80677 +40
Branches 10605 10609 +4
===========================================
- Hits 57201 51185 -6016
- Misses 21776 28018 +6242
+ Partials 1660 1474 -186
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 158 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| proxy_owner = self.base.get_proxy_owner(user) | ||
| if proxy_owner is not None: | ||
| user = proxy_owner |
There was a problem hiding this comment.
Why this change? Isn't the user in the log event the ds proxy instead of the ds owner?
There was a problem hiding this comment.
Isn't the user in the log event the ds proxy instead of the ds owner?
Yes, this is true. However in location_label is the ds owner, so we have to reassign user to the owner of the proxy.
yabirgb
added
the
ready for final review
rotkehlchen/globaldb/cache.py
Outdated
| @@ -70,6 +70,7 @@ def globaldb_get_general_cache_keys_and_values_like( | |||
| """ | |||
| Function to read globaldb cache. | |||
| Returns all pairs key-value where key starts with the provided `key_parts`. | |||
|
|
|||
| `key_parts` should not contain neither `%` nor `.` symbols. | |||
There was a problem hiding this comment.
That's not what I had asked. Look at the review carefully.
key_parts should contain neither the "%" nor the "." symbol.
What you have writen there is double negation. Both here and in the other function please.
Closes #5761
Checklist
DONT FORGET TO MERGE THE CASSETTES BRANCH