feat: setting to render NFTs image

[lukicenturi]

Closes #3975

[codecov]

Codecov Report

Merging #5816 (b93af3f) into develop (2c7a0af) will increase coverage by 0.08%.
The diff coverage is 87.55%.

@@             Coverage Diff             @@
##           develop    #5816      +/-   ##
===========================================
+ Coverage    72.69%   72.78%   +0.08%     
===========================================
  Files         1078     1083       +5     
  Lines       111564   111789     +225     
  Branches      9834     9873      +39     
===========================================
+ Hits         81101    81361     +260     
+ Misses       28997    28963      -34     
+ Partials      1466     1465       -1     

Flag	Coverage Δ
frontend_integration	60.44% <29.29%> (-0.29%)	⬇️
frontend_unit	77.67% <95.78%> (+0.16%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...nts/accounts/management/inputs/InputModeSelect.vue	76.92% <0.00%> (+18.09%)	⬆️
...d/app/src/components/settings/FrontendSettings.vue	100.00% <ø> (ø)
...src/components/settings/general/RefreshSetting.vue	100.00% <ø> (ø)
...nts/settings/general/nft/NftsInNetValueSetting.vue	100.00% <ø> (ø)
frontend/app/src/pages/settings/general/index.vue	100.00% <ø> (ø)
...otkehlchen/chain/ethereum/modules/curve/decoder.py	25.35% <ø> (+0.05%)	⬆️
.../settings/general/nft/NftImageRenderingSetting.vue	50.00% <50.00%> (ø)
frontend/app/src/composables/assets/nft.ts	89.28% <66.66%> (ø)
frontend/app/src/utils/url.ts	93.54% <93.54%> (ø)
frontend/app/src/components/helper/NftDetails.vue	100.00% <100.00%> (ø)
... and 7 more

... and 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[kelsos]

@lukicenturi what is remaining for this? is it ready to re-check?

[lukicenturi]

@lukicenturi what is remaining for this? is it ready to re-check?

Yes it is

[kelsos]

Another question is do you think it would be possible to make it so that you can whitelist a domain from the image component in the nonfungible balances?

[lukicenturi]

Another question is do you think it would be possible to make it so that you can whitelist a domain from the image component in the nonfungible balances?

Yeah it can be worked on

[kelsos]

Ok, so I left a small comment, but overall it is good.

Also, I am thinking, if it would make sense for the table to either show the domain as part of the tooltip or even make it so that you can copy it, what do you think?

For the gallery, you have the whitelist button which makes things easier, but for the table, while you have access to the settings you still don't know the domain.

[lukicenturi]

Ok, so I left a small comment, but overall it is good.

Also, I am thinking, if it would make sense for the table to either show the domain as part of the tooltip or even make it so that you can copy it, what do you think?

For the gallery, you have the whitelist button which makes things easier, but for the table, while you have access to the settings you still don't know the domain.

So for the table, I make the image clickable, to add it to the whitelisted domains

[kelsos]

Ok, so I left a small comment, but overall it is good.
Also, I am thinking, if it would make sense for the table to either show the domain as part of the tooltip or even make it so that you can copy it, what do you think?
For the gallery, you have the whitelist button which makes things easier, but for the table, while you have access to the settings you still don't know the domain.

So for the table, I make the image clickable, to add it to the whitelisted domains

As long as you have to confirm first that should be fine :)

[lukicenturi]

Ok, so I left a small comment, but overall it is good.
Also, I am thinking, if it would make sense for the table to either show the domain as part of the tooltip or even make it so that you can copy it, what do you think?
For the gallery, you have the whitelist button which makes things easier, but for the table, while you have access to the settings you still don't know the domain.

So for the table, I make the image clickable, to add it to the whitelisted domains

As long as you have to confirm first that should be fine :)

It's updated now

[kelsos]

lgtm @lukicenturi thank you very much