Decode transactions that change the content hash of an ENS name #6259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LefterisJP
force-pushed
the
ens_content_hash
branch
from
8075029
to
af343fe
Compare
Due to filips123/ContentHashPy#1 the content-hash library coudl not be used in rotki since its dependencies were too old, they were archived and through transitive dependencies there were incompatibilities with other rotki dependencies. We fix this by forkign content-hash and fixing all of its dependencies to use the more modern multiformats library. We will also make a PR upstream ofc and if they keep maintaining and accept the PR will use the upstream instead.
Codecov Report
@@ Coverage Diff @@
## develop #6259 +/- ##
===========================================
- Coverage 79.92% 73.70% -6.23%
===========================================
Files 1077 1077
Lines 118597 118682 +85
Branches 10564 10581 +17
===========================================
- Hits 94793 87470 -7323
- Misses 22066 29677 +7611
+ Partials 1738 1535 -203
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I will merge. The kyber stuff are probably due to me not having rebased the cassetes repo branch I linked to |
LefterisJP
temporarily deployed
to
cassette-merge
GitHub Actions
Inactive
|
rotki/test-caching/tree/ens_content_hash was successfully merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quickly implemented thanks to the prompt by @kelsos that rotki does not decode it yet properly and the python package hint by @decanus and @pcaversaccio
Decoded transaction
Decoded content hash