cowswap trade fees #6277
Merged
cowswap trade fees #6277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably lots of tests will fail, especially in decoding due to my changes to the way events are shuffled. Will have to address them |
We can now define events of variable length to be preserved in a given order inside the events list. With this new functionality some weird uses of the function are also replaced with a single call Also add a lot more tests for it
Also add test for cowswap accounting with fees
LefterisJP
force-pushed
the
events_orders_cowswap_fee
branch
from
646ebe3
to
af3bb23
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6277 +/- ##
===========================================
+ Coverage 79.97% 80.28% +0.31%
===========================================
Files 1098 1097 -1
Lines 119167 120068 +901
Branches 10684 10728 +44
===========================================
+ Hits 95301 96400 +1099
+ Misses 22132 21928 -204
- Partials 1734 1740 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Well this is all green. nice. Cowswap fees go in then. |
LefterisJP
temporarily deployed
to
cassette-merge
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display fees in cowswap trades and take them into account in accounting
Before:
After
