Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escape quoting in JSON lexer #1297

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

pyrmont
Copy link
Contributor

@pyrmont pyrmont commented Aug 6, 2019

There is a bug in the JSON lexer where the rule from the :name state matches \" when it should be \\". This PR fixes that bug.

No change to the visual sample is required. The error was actually visible but had just not been noticed.

@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Aug 6, 2019
@pyrmont pyrmont merged commit 2b1ef1f into rouge-ruby:master Aug 6, 2019
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Aug 6, 2019
@pyrmont pyrmont deleted the bugfix.json-name-quotes branch January 8, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant