Refactor: Use manual disambiguators for shared filenames #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 23, 2017 16:57
|
This could break manual guessing for custom lexers, though the impact is minor - lexers using the old interface will have their |
|
But! This should give us a clearer way forward when languages share conflicting file extensions. |
jneen
force-pushed
the
refactor.disambiguators
branch
from
4d6955f
to
75c5071
Compare
|
Okay, we're green now. |
|
👏 Things are getting simpler! |
|
(you are welcome to merge this as you like - there may be some minor backcompat issues, so i'll leave it to you to decide how to handle versioning and such) |
|
Merged! Will bump the major version of rouge for the next release. |
This was referenced Sep 13, 2017
This was referenced Sep 21, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of
analyze_text's numeric score interface, and adds a facility for specifying manual disambiguating cases.analyze_texthas been renamed todetect?, which returns a boolean, and is only meant to detect unambiguous cases (like shebangs and doctype declarations).