Better defaults for smtp settings, fixes #24

[aspettl]

This PR contains the most simple implementation for #24: hardcode the defaults, no environment variable.

I tried it locally, it works for me. I modified the readme because the SMTP server has to be specified separately (otherwise it is localhost). And I added tls:// to the example because (hopefully) SMTP servers will require TLS before they accept SMTP AUTH. Anyway, activating encryption should always be a good idea.

[thomascube]

Thanks for getting this done! However, I don't think we should add tls:// in the docker run command example. People tend to copy things without thinking and then complain if it doesn't work. You're certainly right that encryption should be used when connecting to both IMAP and SMTP but in a Docker setup those nodes might be in the same local Docker network and using TLS here might be an unwanted overhead and is maybe not even enabled. It's good to mention it in the variable descriptions but please remove it from the example command.

[aspettl]

I removed the tls:// - but I hope a sysadmin would not be confused by this ;-)

I fear that the risk for someone just trying Roundcube is high that he/she will send a plaintext password over an unsecure connection - without noticing it. (I don't know whether Roundcube refuses to use plaintext passwords without SSL/TLS.)

[aspettl]

Any more issues preventing the merge?

[compuguy]

I removed the tls:// - but I hope a sysadmin would not be confused by this ;-)

I fear that the risk for someone just trying Roundcube is high that he/she will send a plaintext password over an unsecure connection - without noticing it. (I don't know whether Roundcube refuses to use plaintext passwords without SSL/TLS.)

As a sysadmin, I agree with this. That and smtp_user and smtp_pass should be configured to pass-through the login credentials.

[compuguy]

@thomascube Any movement/progress on this pull request?

[thomascube]

Sorry for the delay! Looks good now.

[Fridus]

Hi @aspettl ,
Could you add the parameters ROUNDCUBEMAIL_SMTP_USER and ROUNDCUBEMAIL_SMTP_PASS ?