Fix issue where Content-Length of some attachments could be set to wr…

…ong value causing browser errors (#1490482)
roundcube · Sep 10, 2015 · 77be69f · 77be69f
1 parent 63e7937
commit 77be69f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -65,6 +65,7 @@ CHANGELOG Roundcube Webmail
 - Fix so In-Reply-To header is set also for MDN receipts (#1490523)
 - Fix missing HTTP_X_FORWARDED_FOR address in generated Received header
 - Fix XSS issue in drag-n-drop file uploads (#1490530)
+- Fix issue where Content-Length of some attachments could be set to wrong value causing browser errors (#1490482)
 
 RELEASE 1.1.2
 -------------

diff --git a/program/steps/mail/get.inc b/program/steps/mail/get.inc
@@ -359,9 +359,8 @@ else if (strlen($part_id)) {
                     $sent = true;
                 }
                 else if ($part->size) {
-                    if ($size = (int)$part->d_parameters['size']) {
-                        header("Content-Length: $size");
-                    }
+                    // Don't be tempted to set Content-Length to $part->d_parameters['size'] (#1490482)
+                    // RFC2183 says "The size parameter indicates an approximate size"
 
                     $sent = $MESSAGE->get_part_body($part->mime_id, false, 0, -1);
                 }