Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need to add href="./#NOP" to anchor tags without href attribute. #7413

Closed
kizashi1122 opened this issue Jun 3, 2020 · 1 comment
Closed

No need to add href="./#NOP" to anchor tags without href attribute. #7413

kizashi1122 opened this issue Jun 3, 2020 · 1 comment
Labels
bug C: Mail view
Milestone
1.5-beta

Comments

@kizashi1122
Copy link
Contributor

I don't think it is necessary to add href="./#NOP" to anchor tags without href attribute.

if added href="./#NOP" , it looks clickable (actually nothing happens).

https://github.com/roundcube/roundcubemail/blob/release-1.4/program/steps/mail/func.inc#L1246-L1249

An element without an [href] attribute is still valid.

https://www.w3.org/TR/2011/WD-html5-20110525/text-level-semantics.html#the-a-element

FYI, Gmail does nothing for that element.
@alecpl alecpl added this to the 1.5-beta milestone Jun 6, 2020
alecpl added a commit that referenced this issue Jun 6, 2020
@alecpl
Fix so anchor tags without href attribute are not modified (#7413)
2577270
@alecpl
Copy link
Member

alecpl commented Jun 6, 2020

Fixed.

@alecpl alecpl closed this as completed Jun 6, 2020
alecpl added a commit that referenced this issue Jun 7, 2020
@alecpl
Fix test after change for #7413
77174ff
@smares smares mentioned this issue Jun 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug C: Mail view
Projects
None yet
Milestone
1.5-beta
Development

No branches or pull requests
2 participants
@alecpl @kizashi1122