Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links without defined protocol are replaced with ./#NOP on message content #7454

Closed
lucasmarin opened this issue Jun 25, 2020 · 3 comments
Closed

Links without defined protocol are replaced with ./#NOP on message content #7454

lucasmarin opened this issue Jun 25, 2020 · 3 comments
Labels
bug C: Mail view
Milestone
1.4.8

Comments

@lucasmarin
Copy link
Contributor

Links without protocol on href attribute on "A" html tag are replaced with ./#NOP on the message view

A message with this html content:

<html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; charset=
=3DUTF-8" /></head><body style=3D'font-size: 10pt; font-family: Verdana,Gen=
eva,sans-serif'>
<div><a href=3D"www.lalala.com.br">teste</a></div>
<div>&nbsp;</div>
<div>&nbsp;</div>
<div>&nbsp;</div>
<div><br />
</div>
</body></html>

is replaced by:

<div class="rcmBody" style="font-size: 10pt; font-family: Verdana,Geneva,sans-serif">
<div><a href="./#NOP" onclick="return false" rel="noreferrer">teste</a></div>
<div>&nbsp;</div>
<div>&nbsp;</div>
<div>&nbsp;</div>
</div>

Examples of messages with this behaviour

teste1.eml
teste2.eml

I tested on gmail, hotmail and outlook and the protocol http:// is inserted on link.

RC Version: 1.4.6
@smares
Copy link
Contributor

smares commented Jun 26, 2020

Duplicate of #7413

@alecpl alecpl closed this as completed Jun 26, 2020
@alecpl alecpl reopened this Jun 26, 2020
@alecpl
Copy link
Member

alecpl commented Jun 26, 2020

This is not exactly a duplicate. In git-master the href is removed. Maybe we could be smarter and allow "safe" href values in such cases. I'm not sure we should add the protocol prefix.

In Thunderbird the link looks like a link, but does not work, i.e. it does not add http:// to the href.

@alecpl alecpl added this to the later milestone Jun 26, 2020
@alecpl alecpl modified the milestones: later, 1.4.8 Jul 29, 2020
@alecpl alecpl added bug and removed enhancement labels Jul 29, 2020
alecpl added a commit that referenced this issue Jul 29, 2020
@alecpl
Fix handling links without defined protocol (#7454)
17deadf
alecpl added a commit that referenced this issue Jul 29, 2020
@alecpl
Fix handling links without defined protocol (#7454)
247b22d
@alecpl
Copy link
Member

alecpl commented Jul 29, 2020

Fixed.

@alecpl alecpl closed this as completed Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug C: Mail view
Projects
None yet
Milestone
1.4.8
Development

No branches or pull requests
3 participants
@lucasmarin @alecpl @smares