Cleanup: Plugins #2 - Various #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddeutsch
commented
Aug 29, 2013
daviddeutsch
commented
- /attachment_reminder
- /autologon
- /database_attachments
- /debug_logger
re-instancing of rcmail here. Checked the code and could find none.
| rcmail.env.attachment_reminder = false; | ||
| rcmail.show_popup_dialog(rcmail.gettext('attachment_reminder.forgotattachment'), '', buttons); | ||
| }; | ||
| function rcmail_get_compose_message() { |
There was a problem hiding this comment.
I'd like a newline before { here
There was a problem hiding this comment.
Agreed, these should be analogous to the style in PHP code.
|
There you go 😉 (Breakfast time now, but keep em coming!) |
|
|
||
| $field_id = 'rcmfd_attachment_reminder'; | ||
|
|
||
| $checkbox = new html_checkbox(array('name' => '_attachment_reminder', 'id' => $field_id, 'value' => 1)); |
There was a problem hiding this comment.
We really loose much vertical space this way. If there are no comments, do not add empty lines. Here, I'd add only one new line, after $this->add_texts() call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.