managesieve: fix bug when opening exists rule #5899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecpl
reviewed
Aug 19, 2017
| @@ -677,7 +677,7 @@ function rule_header_select(id) | |||
| dateheader.style.display = h == 'date' ? '' : 'none'; | |||
|
|
|||
| $('[value="exists"],[value="notexists"]', rule).prop('disabled', h == 'string'); | |||
| if (!rule.val() || rule.val().match(/^(exists|notexists)$/)) | |||
| if (!rule.val() && !rule.val().match(/^(exists|notexists)$/)) | |||
There was a problem hiding this comment.
This code does not make sense now. I think the point was to reset the select to 'contains' if the selected value was disabled. In such cases the rule.val() will return null and there will be a javascript error. So, I think just
if (!rule.val())
rule.val('contains');
should be enough. Thanks for spotting this issue.
alecpl
added a commit
that referenced
this pull request
Aug 19, 2017
alecpl
added a commit
that referenced
this pull request
Aug 19, 2017
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you create a rule in managesieve and set the test the to exists.
For example Subject Exists. Save it. navigate away and then open that rule up again the form will load with Subject Contains.
This is a little tweak just to make it load the form with Subject Exists.