Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

method round buggy #84

Closed
Adamko23 opened this issue Oct 13, 2022 · 1 comment · Fixed by #86
Closed

method round buggy #84

Adamko23 opened this issue Oct 13, 2022 · 1 comment · Fixed by #86
Assignees
@royNiladri

Comments

@Adamko23
Copy link

method "round" returns only positive results, for example:
bigDecimal.round(-0.1234, 2); returns 0.12, but not -0.12
royNiladri added a commit that referenced this issue Oct 27, 2022
@royNiladri
Bugfix #84 fixed buggy round
fd6adb7
royNiladri added a commit that referenced this issue Oct 27, 2022
@royNiladri
Bugfix #84 (#86)
682c150 
* Bugfix #84 fixed buggy round

* 1.3.11

* 1.3.12
@royNiladri royNiladri linked a pull request Oct 27, 2022 that will close this issue
Bugfix #84 #86
Merged
@royNiladri
Copy link
Owner

Fixed in v1.3.12

royNiladri added a commit that referenced this issue Dec 3, 2022
@royNiladri
Bugfix #63 (#87)
7518da2 
* Bugfix #84 fixed buggy round

* 1.3.11

* 1.3.12

* bugfix #63: fix addition of -0

* build files

* 1.3.13
royNiladri added a commit that referenced this issue Jan 3, 2023
@royNiladri
feature: abs (#90)
7d82c5c 
* Bugfix #84 fixed buggy round

* 1.3.11

* 1.3.12

* bugfix #63: fix addition of -0

* build files

* 1.3.13

* added devcontainer

* changed gulpfile for macos

* added feature 'abs' #83

* 1.3.14

* added abs to readme

* 1.3.15
royNiladri added a commit that referenced this issue Feb 11, 2023
@royNiladri
feature-request #92 (#93)
863ff87 
* Bugfix #84 fixed buggy round

* 1.3.11

* 1.3.12

* bugfix #63: fix addition of -0

* build files

* 1.3.13

* added devcontainer

* changed gulpfile for macos

* added feature 'abs' #83

* 1.3.14

* added abs to readme

* 1.3.15

* semantic dependency updates

* Add feature for #32 setValue

* 1.4.0

* Merge branch 'master' of https://github.com/royNiladri/js-big-decimal into development

* upadted packagelock

* 1.4.1

---------

Co-authored-by: Niladri Roy <niroy@informatica.com>
royNiladri added a commit that referenced this issue Aug 2, 2023
@royNiladri @NiloCK
Esm support added [from NiloCK](#100)
1d2d912 
* Bugfix #84 fixed buggy round

* 1.3.11

* 1.3.12

* bugfix #63: fix addition of -0

* build files

* 1.3.13

* added devcontainer

* changed gulpfile for macos

* added feature 'abs' #83

* 1.3.14

* added abs to readme

* 1.3.15

* semantic dependency updates

* Add feature for #32 setValue

* 1.4.0

* Merge branch 'master' of https://github.com/royNiladri/js-big-decimal into development

* upadted packagelock

* 1.4.1

* Add an ESM compatible build to grunt script via Rollup (#99)

* add rollup dev dependencies

* change export mechanism...

This does not change the `dist` command's current outputs

* add rollup es module bundling to grunt dist task

* Fix typo

* add "module" esm target file

* add built esm outputs

* fixed tests for esm

* 2.0.0

---------

Co-authored-by: Niladri Roy <niroy@informatica.com>
Co-authored-by: Colin Kennedy <NiloCK@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@royNiladri royNiladri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix #84 royNiladri/js-big-decimal
2 participants
@royNiladri @Adamko23